Make it possible for users to view their data on Panorama Public #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Jan 9, 2024
| } | ||
| } | ||
|
|
||
| public static class MyDataForm |
There was a problem hiding this comment.
Do we need this form at all? It seems like we only support viewing data for the current user.
There was a problem hiding this comment.
No, we don't need a userId since we are only displaying the data for the currently logged in user! I removed the form.
| return; | ||
| } | ||
| } | ||
| HtmlString.EMPTY_STRING.appendTo(out); |
There was a problem hiding this comment.
This codepath uses EMPTY_STRING and the one above uses NBSP. I imagine they should probably use the same placeholder, though maybe it doesn't make a difference.
…g.NBSP consistently) - Use return URL, when available, for rendering the back button in the CatalogEntryWebPart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a "My Data" button in the "Panorama Public Experiments" button bar. The button is displayed if a user is logged in. It links to MyDataViewAction.
My Data view displays a grid filtered to the user's public and private datasets on Panorama Public. These are experiments where the user is either a "submitter" or the "lab head".
The "My Data" grid displays a "Catalog Entry" column that can be used to add or view catalog entries for public datasets. Catalog entries cannot be added for private datasets.